Skip to content

Make pmjs & peter-jr work on Windows#139

Merged
zollqir merged 15 commits intomainfrom
Xmader/fix/readline-windows
Jul 21, 2023
Merged

Make pmjs & peter-jr work on Windows#139
zollqir merged 15 commits intomainfrom
Xmader/fix/readline-windows

Conversation

@Xmader
Copy link
Copy Markdown
Member

@Xmader Xmader commented Jul 20, 2023

Closes #111

@Xmader
Copy link
Copy Markdown
Member Author

Xmader commented Jul 20, 2023

Blocked by #81 (wesgarland/ctx-module#3)

@Xmader Xmader added the blocked blocked by another PR or Issue label Jul 20, 2023
Xmader added 2 commits July 20, 2023 22:15
`pyreadline3` on Windows would throw `Readline internal error` if calling `sys.exit` directly inside the REPL loop
@Xmader Xmader requested a review from wesgarland July 20, 2023 22:59
@Xmader Xmader marked this pull request as ready for review July 21, 2023 00:13
@Xmader Xmader added this to the v0.2.0 milestone Jul 21, 2023
@Xmader Xmader changed the base branch from main to Xmader/perf/convert-date-by-timestamp July 21, 2023 07:52
Base automatically changed from Xmader/perf/convert-date-by-timestamp to main July 21, 2023 13:12
Copy link
Copy Markdown
Collaborator

@zollqir zollqir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zollqir zollqir merged commit 09b5b37 into main Jul 21, 2023
@zollqir zollqir deleted the Xmader/fix/readline-windows branch July 21, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked blocked by another PR or Issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make pmjs repl work on win32

2 participants